KEMBAR78
fix crash issue when using shadowfile with pretty #17853 by changhoetyng · Pull Request #17894 · python/mypy · GitHub
Skip to content

fix crash issue when using shadowfile with pretty #17853 #17894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix crash issue when using shadowfile with pretty #17853 #17894

merged 4 commits into from
Oct 11, 2024

Conversation

changhoetyng
Copy link
Contributor

@changhoetyng changhoetyng commented Oct 7, 2024 •
edited
Loading

  • Fix crash issue when using --pretty with --shadow-file

Example Scenario:
a.py

b: bytes

b.py

a: int = ""
b: bytes = 1

output

$ mypy a.py --pretty --shadow-file a.py b.py
a.py:1: error: Incompatible types in assignment (expression has type "str",
variable has type "int")
    a: int = ""
             ^~
a.py:2: error: Incompatible types in assignment (expression has type "int",
variable has type "bytes")
    b: bytes = 1
               ^

Fixes #17853

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
JukkaL
JukkaL approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JukkaL JukkaL merged commit b1701e5 into python:master Oct 11, 2024
18 checks passed
@changhoetyng changhoetyng deleted the test-#17853 branch October 14, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in --pretty mode with --shadow-file which shadows a shorter file

2 participants

@changhoetyng @JukkaL