Better error for mypy -p package without py.typed
#17908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Nice! Looking at find_modules_recursive, I think we can be a little more helpful. if not p_targets, let's call find_module directly, if the module not found reason is found without type hints, we can confidently say py.typed is missing (and otherwise we can fail with the existing message)
This comment has been minimized.
This comment has been minimized.
hauntsaninja
changed the title
mypy -p package without py.typed
|
test failure seems to be unrelated and not sure how to retry it |
|
Don't worry about it, I'll take care of that :-) Thanks again for the improvement! |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the error message when running
mypy -p packagenamewith apackage that doesn't have py.typed set.
Fix #17048