KEMBAR78
Fix approved stub ignore, remove normpath by hauntsaninja · Pull Request #18045 · python/mypy · GitHub
Skip to content

Fix approved stub ignore, remove normpath #18045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2024
Merged

Fix approved stub ignore, remove normpath #18045

merged 2 commits into from
Oct 26, 2024

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 25, 2024 •
edited
Loading

Follow up to #18038

This maybe should have been two PRs

@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Oct 25, 2024 •
edited
Loading

Benchmark on an earlier version of this PR. Looks like 0.3s saving on long and 0.7s saving on openai

+ /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy --version
mypy 1.14.0+dev.ecf539147dfebcbe0d1b3817729bcf618ac5c286 (compiled: yes)
+ hyperfine -w 1 -M 5 --export-json benchjson/ecf5391_clean.json '/tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c '\''import torch'\'' --no-incremental --python-executable clean/bin/python'
Benchmark 1: /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c 'import torch' --no-incremental --python-executable clean/bin/python
  Time (mean ± σ):     19.751 s ±  0.322 s    [User: 18.340 s, System: 1.397 s]
  Range (min … max):   19.522 s … 20.312 s    5 runs
 
+ hyperfine -w 1 -M 5 --export-json benchjson/ecf5391_long.json '/tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c '\''import torch'\'' --no-incremental --python-executable long/bin/python'
Benchmark 1: /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c 'import torch' --no-incremental --python-executable long/bin/python
  Time (mean ± σ):     19.929 s ±  0.342 s    [User: 18.567 s, System: 1.349 s]
  Range (min … max):   19.533 s … 20.461 s    5 runs
 
+ hyperfine -w 1 -M 5 --export-json benchjson/ecf5391_oai.json '/tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c '\''import torch'\'' --no-incremental --python-executable /opt/oai/bin/python'
Benchmark 1: /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c 'import torch' --no-incremental --python-executable /opt/oai/bin/python
  Time (mean ± σ):     26.182 s ±  0.300 s    [User: 24.031 s, System: 2.130 s]
  Range (min … max):   25.862 s … 26.671 s    5 runs
 
+ hyperfine -w 2 -M 5 --export-json benchjson/ecf5391_clean_inc.json '/tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c '\''import torch'\'' --python-executable clean/bin/python'
Benchmark 1: /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c 'import torch' --python-executable clean/bin/python
  Time (mean ± σ):      2.065 s ±  0.012 s    [User: 1.696 s, System: 0.369 s]
  Range (min … max):    2.051 s …  2.084 s    5 runs
 
+ hyperfine -w 2 -M 5 --export-json benchjson/ecf5391_long_inc.json '/tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c '\''import torch'\'' --python-executable long/bin/python'
Benchmark 1: /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c 'import torch' --python-executable long/bin/python
  Time (mean ± σ):      2.093 s ±  0.012 s    [User: 1.733 s, System: 0.359 s]
  Range (min … max):    2.079 s …  2.106 s    5 runs
 
+ hyperfine -w 2 -M 5 --export-json benchjson/ecf5391_oai_inc.json '/tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c '\''import torch'\'' --python-executable /opt/oai/bin/python'
Benchmark 1: /tmp/mypy_primer/timer_mypy_ecf5391/venv/bin/python -m mypy -c 'import torch' --python-executable /opt/oai/bin/python
  Time (mean ± σ):      3.239 s ±  0.075 s    [User: 2.685 s, System: 0.553 s]
  Range (min … max):    3.179 s …  3.344 s    5 runs

@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja
Copy link
Collaborator Author

The primer is a true negative (i.e. types-pyOpenSSL is installed). You can see it get introduced when regressed here: #15347 (comment)

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

scrapy (https://github.com/scrapy/scrapy)
- scrapy/utils/ssl.py:5: error: Library stubs not installed for "OpenSSL._util"  [import-untyped]
- scrapy/utils/ssl.py:5: note: Hint: "python3 -m pip install types-pyOpenSSL"
- scrapy/utils/ssl.py:5: note: (or run "mypy --install-types" to install all missing stub packages)
- scrapy/utils/ssl.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

@hauntsaninja hauntsaninja merged commit 2b033cb into python:master Oct 26, 2024
19 checks passed
@hauntsaninja hauntsaninja deleted the search-path-fix branch October 26, 2024 02:11
@hauntsaninja hauntsaninja mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hauntsaninja