KEMBAR78
Emit `[mutable-override]` for covariant override of attribute with method by brianschubert · Pull Request #18058 · python/mypy · GitHub
Skip to content

Emit [mutable-override] for covariant override of attribute with method #18058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2024
Merged

Emit [mutable-override] for covariant override of attribute with method #18058

merged 1 commit into from
Oct 27, 2024

Conversation

brianschubert
Copy link
Member

Fixes #18052

Given:

# flags: --enable-error-code=mutable-override
from typing import Callable

class Parent:
    func: Callable[[str], None]

class Child(Parent):
    def func(self, x: object) -> None: pass

Before:

Success: no issues found in 1 source file

After:

main.py:7 error: Covariant override of a mutable attribute (base class "Parent" defined the type as "Callable[[str], None]", override has type "Callable[[object], None]")
Found 1 error in 1 file (checked 1 source file)

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 7f09f0c into python:master Oct 27, 2024
19 checks passed
@hauntsaninja
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overriding callable attribute with method not caught by [mutable-override]

2 participants

@brianschubert @hauntsaninja