KEMBAR78
Set default strict_optional state to True by hauntsaninja · Pull Request #18198 · python/mypy · GitHub
Skip to content

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

@github-actions

This comment has been minimized.

@hauntsaninja
Copy link
Collaborator Author

Looks like some of the strict optional behaviour is a little buggy, e.g. not symmetric join / meet

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 15cd6d3 into python:master Nov 27, 2024
19 checks passed
@hauntsaninja hauntsaninja deleted the mypy-state branch November 27, 2024 04:21
@cdce8p
Copy link
Collaborator

cdce8p commented Nov 27, 2024

Should we consider removing the --implicit-optional and --no-strict-optional options and related code all together, maybe for the 2.0 release (#17967)?

--implicit-optional was disabled by default in 0.980.

@JukkaL
Copy link
Collaborator

JukkaL commented Nov 27, 2024

We still use --no-strict-optional for some legacy code at work. Migrating away from it can be tricky, so we may have to keep it around for a long time. --implicit-optional doesn't need much maintenance, so I think we can also keep it around. It's hard to know how popular various flags are in private codebases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants