Allow inverting --local-partial-types #18377
Conversation
This comment has been minimized.
This comment has been minimized.
Also add it to a bunch of test cases where it is needed
hauntsaninja
force-pushed
the
partial-invert
branch
from
cc436e1 to
4cd99a8
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
|
||
| [case testBoundVoid] | ||
| # flags: --no-strict-optional | ||
| # flags: --no-strict-optional --no-local-partial-types |
There was a problem hiding this comment.
Making --local-partial-types invertible will certainly help which it's adoption. E.g. we could also consider adding it to --strict as a first step before making it the default in 2.0.
I do just wonder what change made the test diffs necessary. Adding add_invertible_flag with default=False shouldn't change anything, does it?
It will probably make sense to enable it for all our tests by default, but in that case the test config should probably be changed in the same PR. E.g. it could be added here.
Lines 128 to 131 in 55d4c17
--
Feel free to split that up into a different PR if you like though.
There was a problem hiding this comment.
Oh, it wasn't necessary, I was just testing that the PR worked by changing the default locally and proactively added it to test cases where I felt confident it was what we needed
There was a problem hiding this comment.
Yeah, changing default in tests is not a bad idea
2 participants
Also add it to a bunch of test cases where it is needed