Dedicated error code for explicit any #18398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
commented
Dec 31, 2024
|
|
||
| .. _code-narrowed-type-not-subtype: | ||
|
|
||
| Check that ``TypeIs`` narrows types [narrowed-type-not-subtype] |
There was a problem hiding this comment.
this is on by default, so moving it to the correct page while i'm here
hauntsaninja
force-pushed
the
explicit-any
branch
from
c9c39dd to
5f9b330
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: trio (https://github.com/python-trio/trio)
+ src/trio/_core/_thread_cache.py:219: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_thread_cache.py:219: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_thread_cache.py:219: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_util.py:24: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_util.py:24: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_util.py:24: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_util.py:181: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_util.py:181: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_util.py:181: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_util.py:189: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_util.py:189: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_util.py:189: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_util.py:253: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_util.py:253: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_util.py:253: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_util.py:350: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_util.py:350: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_util.py:350: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_util.py:353: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_util.py:353: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_util.py:353: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_highlevel_serve_listeners.py:29: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_highlevel_serve_listeners.py:29: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_highlevel_serve_listeners.py:29: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_highlevel_serve_listeners.py:72: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_highlevel_serve_listeners.py:72: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_highlevel_serve_listeners.py:72: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_traps.py:108: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_traps.py:108: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_traps.py:108: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_socket.py:50: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_socket.py:50: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_socket.py:50: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_instrumentation.py:15: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_instrumentation.py:15: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_instrumentation.py:15: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_instrumentation.py:21: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_instrumentation.py:21: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_instrumentation.py:21: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_file_io.py:431: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_file_io.py:431: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_entry_queue.py:20: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_entry_queue.py:20: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_entry_queue.py:20: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_ssl.py:427: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_ssl.py:427: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_ssl.py:427: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_highlevel_open_tcp_stream.py:138: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_highlevel_open_tcp_stream.py:138: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_highlevel_open_tcp_stream.py:138: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1291: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1291: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1291: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1391: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1391: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1391: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1394: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1394: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1394: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1413: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1413: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1413: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1414: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1414: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1414: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1416: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1416: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1416: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1484: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1484: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1484: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1630: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1630: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1630: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1635: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1635: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1635: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1638: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1638: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1638: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1684: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1684: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:1684: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1693: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:1693: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:1693: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:2121: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:2121: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:2121: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_run.py:2423: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_run.py:2423: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_run.py:2423: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:150: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:150: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:150: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_threads.py:151: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_threads.py:151: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:151: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:210: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:210: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:210: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_threads.py:211: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_threads.py:211: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:211: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:255: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:255: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:528: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_threads.py:528: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:528: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_threads.py:573: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_threads.py:573: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_threads.py:573: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_path.py:34: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_path.py:34: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_path.py:34: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_path.py:187: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_path.py:187: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_path.py:197: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/testing/_fake_net.py:511: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/testing/_fake_net.py:511: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/testing/_fake_net.py:511: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_tests/test_subprocess.py:86: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_tests/test_subprocess.py:99: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_tests/test_subprocess.py:119: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_tests/test_subprocess.py:119: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_tests/test_subprocess.py:119: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_tests/test_ssl.py:385: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_tests/test_ssl.py:385: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_tests/test_ssl.py:385: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_tests/test_run.py:1662: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_tests/test_run.py:1662: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_tests/test_run.py:1662: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_tests/test_run.py:1700: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_tests/test_run.py:1700: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_tests/test_run.py:1700: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_tests/test_run.py:1706: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_tests/test_run.py:1706: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_tests/test_run.py:1706: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_core/_tests/test_ki.py:681: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_core/_tests/test_ki.py:681: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_core/_tests/test_ki.py:681: note: Error code "explicit-any" not covered by "type: ignore" comment
+ src/trio/_tests/test_threads.py:59: error: Unused "type: ignore" comment [unused-ignore]
+ src/trio/_tests/test_threads.py:59: error: Explicit "Any" is not allowed [explicit-any]
+ src/trio/_tests/test_threads.py:59: note: Error code "explicit-any" not covered by "type: ignore" comment
|
|
I know the diff for trio looks bad, but we're already generally writing out explanations for this so this change is good: -snip, I misread a note as an error- |
|
Yup, I got here because I realised I could batch some type ignore thrash for trio here: #18397 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.