KEMBAR78
[stubgen] Fix UnpackType for 3.11+ by cdce8p · Pull Request #18421 · python/mypy · GitHub
Skip to content

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 6, 2025

Don't replace *Ts with Unpack[Ts] on Python 3.11+.
This is broken currently since Unpack isn't added as import in the stub file.

@cdce8p cdce8p added topic-stubgen topic-pep-646 PEP 646 (TypeVarTuple, Unpack) labels Jan 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 306c1af into python:master Jan 7, 2025
19 checks passed
@cdce8p cdce8p deleted the stubgen-unpack branch January 7, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-pep-646 PEP 646 (TypeVarTuple, Unpack) topic-stubgen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants