Fix parent generics mapping when overriding generic attribute with property #18441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Jan 11, 2025
|
LG, but now there is a merge conflict. |
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/ext/csgo/client.py:52: note: cached_property[Self, steam._gc.client.ClientUser]
+ steam/ext/csgo/client.py:52: note: cached_property[Client, steam._gc.client.ClientUser]
- steam/ext/tf2/client.py:52: note: cached_property[Self, steam._gc.client.ClientUser]
+ steam/ext/tf2/client.py:52: note: cached_property[Client, steam._gc.client.ClientUser]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18189.
Following #18415, this fixes one more place where parent class generics aren't mapped to attributes correctly.