KEMBAR78
Ignore overload impl when checking __OP__ and __rOP__ compatibility by sterliakov · Pull Request #18502 · python/mypy · GitHub
Skip to content

Conversation

sterliakov
Copy link
Collaborator

Fixes #18498

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sterliakov sterliakov marked this pull request as ready for review January 21, 2025 22:49
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simple flag would have been sufficient, but likely there is not much difference in performance anyway.

@ilevkivskyi ilevkivskyi merged commit 0c26253 into python:master Jun 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different overlap checking between __mul__ and __rmul__

2 participants