Fix swapped errors for frozen/non-frozen dataclass inheritance #18918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nawrazi
changed the title
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! I think the current phrasing is a bit confusing. I'd suggest rewording these as |
brianschubert
approved these changes
Apr 13, 2025
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mix-up in error messages related to frozen and non-frozen dataclass inheritance.
Currently:
Inheriting a frozen dataclass from a non-frozen one incorrectly gives the error:
Cannot inherit non-frozen dataclass from a frozen oneInheriting a non-frozen dataclass from a frozen one gives the error:
Cannot inherit frozen dataclass from a non-frozen oneThis PR swaps these two error messages and rephrases them for better clarity.