[mypyc] Fix spilling values with overlapping error values #18961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update spilling transform for async and generator functions to not require a defined attribute bitfield. We now treat temporary values with overlapping errors values as always defined. This would be more difficult to do for reference counted values, so we don't do this for all values.
svalentin
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spilling transform for async and generator functions to not require a defined attribute bitfield. We now treat temporary spilled values with overlapping error values as always defined. I'm not sure if this would be safe to do for reference counted values, so we only do this in cases where it's clearly fine.