Bug fix of __r<magic_methods>__ being used under the same __<magic_method>__ hook #18995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
yippee |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sterliakov
approved these changes
Apr 29, 2025
|
Yippee |
|
@hauntsaninja could you post/link this to #6617 (it's locked, I can't write there)? I don't think this breaks someone's workflow, but better be cautious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18945 (This was a feature request that turned out to be a bug)
Essentially, I was trying to create a custom plugin and implement add. In the process I discovered that radd would implicitly be called if add has an error but it would be called under the same add hook (instead of radd) which is bad for non-commutative operations. This has been fixed.
I also added a test for it.