Infer empty list without annotation for __slots__ and module __all__
#19348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sterliakov
changed the title
__slots____slots__
sterliakov
changed the title
__slots____slots__ and module __all__
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Jun 27, 2025
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Jun 27, 2025
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10870, fixes #10103.
This adds a fake
Iterable[str]context when checking the following:__all__ = []at top level__slots__ = []at class level (also works for sets but not for dicts)Additionally, this fixes a bug with
__slots__being mistakenly checked in other contexts (at top level or in function bodies), so e.g. the following is now accepted: