Mypy micro-optimizations (batch 1/3) #19768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Aug 31, 2025
cdce8p
reviewed
Sep 1, 2025
Comment on lines
-2126
to
+2128
| self.variables = variables | ||
| self.variables: tuple[TypeVarLikeType, ...] | ||
| if variables is None: | ||
| self.variables = () | ||
| else: | ||
| self.variables = tuple(variables) |
There was a problem hiding this comment.
Note, this does crash the pydantic.v1 extension.
File "/.../python3.13/site-packages/pydantic/v1/mypy.py", line 868, in add_method
signature.variables = [tvar_def]
^^^^^^^^^^^^^^^^^^^
TypeError: tuple object expected; got listhttps://github.com/pydantic/pydantic/blob/v2.11.7/pydantic/v1/mypy.py#L866-L868
It can fairly easily be fixed and I'll open a PR for it soon. However, that might not be the only plugin which depends on it being "just" a sequence.
There was a problem hiding this comment.
If we have evidence that this impacts multiple plugins, we can consider reverting this change.
This was referenced Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several mypy micro-optimizations. Together with batches 2 and 3 these improve self check performance by 1.8%.