Add --find-occurrences experimental option #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh cool, this is something I would often do by just renaming the thing and seeing what errors popped up, but if you're using incremental then that isn't a great way to do it. |
|
Unfortunately if you're using incremental this isn't a great way to do it either... Making this work properly/efficiently with incremental would be a lot more work, and is potentially pretty complicated. |
|
Is this worth keeping open? |
gvanrossum
changed the title
ddfisher
force-pushed
the
future/find-occurrences-prototype
branch
from
370de22 to
95ae167
Compare
ddfisher
changed the title
|
@gvanrossum thoughts on merging this? It's pretty constrained at the moment, but isn't much code and is super useful in certain circumstances. |
|
Yeah, this is pretty handy. I've merged it. I recommend that you also add something to the docs; I had to try a few times before I found the right way to use it (it doesn't take module names at all). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is too hacky to merge, but I thought I'd put it up because it might be helpful to other people/to start a discussion.
Current problems:
experimentsmodule to get a global variable insideanalyze_member_accessI've found it super useful already, though.