[clean strict optional] Fix some strict optional errors in mypy #3228
Conversation
|
|
||
| def analyze_conversion_specifiers(self, specifiers: List[ConversionSpecifier], | ||
| context: Context) -> bool: | ||
| context: Context) -> Optional[bool]: |
There was a problem hiding this comment.
The code below distinguishes False and None
| xsd_path = os.path.join(reports.data_dir, 'xml', 'mypy.xsd') | ||
| self.schema = etree.XMLSchema(etree.parse(xsd_path)) | ||
| self.last_xml = None # type: etree._ElementTree | ||
| self.last_xml = None # type: Optional[etree._ElementTree] |
There was a problem hiding this comment.
I wonder if it wouldn't be better to keep this as non-optional and remove the None assignments? Not sure I follow the logic there.
There was a problem hiding this comment.
If I understand the logic correctly, those None assignments are needed, but the attribute should be always non-None at the end, so that I replaced ifs with asserts, I checked locally it works correctly.
mypy/strconv.py
Outdated
|
|
||
| def __init__(self, show_ids: bool = False) -> None: | ||
| self.show_ids = show_ids | ||
| self.id_mapper = None # type: IdMapper |
There was a problem hiding this comment.
Why not Optional? (Currently mypy ignores the None initialization but we may change that, and it seems to me this function can definitely return with id_mapper still None.
mypy/stubutil.py
Outdated
|
|
||
|
|
||
| def write_header(file: IO[str], module_name: str, pyversion: Tuple[int, int] = (3, 5)) -> None: | ||
| def write_header(file: IO[str], module_name: str = None, |
There was a problem hiding this comment.
I prefer Optional[str], EIBTI. (I somewhat regret the rule in PEP 484 about this, or at least I don't enjoy relying on it.)
There was a problem hiding this comment.
OK, I will use Optional[X] (also for previous comment) in this and next PRs. I don't have a preference concerning "syntactic sugar" just would prefer this to be consistent in function annotations and variable annotations (i.e. either both or neither).
I will implement your comments tomorrow, sorry don't have time today.
|
Thanks! Let's remember to mark these files with |
2 participants
This PR fixes 26
--strict-optionalerrors in mypy itself (out of 547 total) in following files: