Invalidate metadata if errors were previously ignored #3793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using --incremental with --follow-imports=silent triggered a bug where a file was not typechecked due to the presence of a metadata file and accompanying AST from a previous run and would therefore not print any errors. This diff fixes the issue by recording whether errors were silenced in the metadata file when it was created and ignoring these files if errors are no longer silenced.
|
Sorry, it's vacation season and there are few people around to review this. We'll get to it. |
|
LG, waiting for the tests to pass after the resolve. |
|
Thanks! This addresses a nasty obscure corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using --incremental with --follow-imports=silent triggered a bug where a
file was not typechecked due to the presence of a metadata file
and accompanying AST from a previous run and would therefore not print any
errors. This diff fixes the issue by recording whether errors were
silenced in the metadata file when it was created and ignoring these files if
errors are no longer silenced.
Fixes #3639