Don't crash on unexpected PY2 except syntax #4011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatyping
reviewed
Sep 26, 2017
mypy/fastparse2.py
Outdated
| raise RuntimeError("'{}' has non-Name name.".format(ast27.dump(item))) | ||
|
|
||
| vs = [produce_name(h) for h in handlers] | ||
| self.fail("Sorry, `except <expr>, (<tuple>)` is not supported", item.lineno, item.col_offset) |
There was a problem hiding this comment.
This could be something other than a tuple however. For example, this works fine at runtime:
try:
raise Exception('foo', 'bar')
except Exception, [a, b]:
print a, b # prints foo barPerhaps just "Unsupported exception handler syntax ...". If you want a specific warning, you can check that the item.name is an ast27.Tuple or ast27.List.
There was a problem hiding this comment.
I'll change it to except <expr>, <anything but a name> -- it's syntactically an assignment target. I still don't think it's worth trying to support other syntax -- we just need to not crash.
|
Whoa, needs tests first. |
|
Sorry, yes it needs tests. I meant the changes look good (beyond needing tests). |
|
Travis flaked on 3.7, so I restarted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3772
Still needs a test.