Never put None in TupleType items #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked our internal codebase and everything's fine. Thanks for the quick fix! I'll ponder it a little bit and then probably cherry-pick. |
|
This fixes the issue for us as well. Thanks @ilevkivskyi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4046
The root cause for the crash is that
Nonewas put inTupleTypeitems if the correspondinglvalueis a definition. Then the crash happens when thisTupleTypeis used as a context forrvaluetype inference. The solution is to putUninhabitedTypein such cases, so that inference will fall back on using argument types instead.This PR should not cause any crashes but it makes sense to test it against internal codebases since it touches an area that might alter type inference in corner cases.