Thread line/col for lambda parameter to error about covariant typevar #4275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilevkivskyi Do you think this is the right solution? I spiked on just this error, not sure how many others are similar. |
ilevkivskyi
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
This is an old problem. There are few open similar issues still (for example #4231), but I think most of things are fixed now. The situation with column numbers is worse however. I think we need more tests for columns, or we can just update existing tests, I will now open an issue for this.
| defn.name() not in ('__init__', '__new__') | ||
| ): | ||
| self.fail(messages.FUNCTION_PARAMETER_CANNOT_BE_COVARIANT, arg_type) | ||
| ctx = arg_type # type: Context |
There was a problem hiding this comment.
I would add a test where problematic argument appears on a separate line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4270