KEMBAR78
Allow calling TupleTypes if the fallback can be called by msullivan · Pull Request #4367 · python/mypy · GitHub
Skip to content

Allow calling TupleTypes if the fallback can be called #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2017
Merged

Allow calling TupleTypes if the fallback can be called #4367

merged 2 commits into from
Dec 16, 2017

Conversation

@msullivan
Copy link
Collaborator

Fixes #4360

@gvanrossum
Copy link
Member

Would you consider adding a test where __call__ takes args and returns a relevant value? (Just being paranoid here.)

ilevkivskyi
ilevkivskyi reviewed Dec 15, 2017
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right fix, but could you please add more tests:

  • With classes inheriting normal tuple instead of named tuple
  • With forward references (where classes are defined after the call)
  • With more complex __call__ methods and reveal_type.

@msullivan
Copy link
Collaborator Author

Added more testing. Our documentation claims that Tuple can't be subclassed directly, which is why I was testing with NamedTuple.

@ilevkivskyi
Copy link
Member

Added more testing. Our documentation claims that Tuple can't be subclassed directly, which is why I was testing with NamedTuple.

The docs need to be updated, would you like to make a PR?

@ilevkivskyi ilevkivskyi merged commit 080e345 into master Dec 16, 2017
@ilevkivskyi ilevkivskyi deleted the call-tuple branch December 16, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msullivan @gvanrossum @ilevkivskyi