Refuse to run under 3.5.0 or anything before 3.4 #4721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatyping
requested changes
Mar 12, 2018
mypy/main.py
Outdated
| if vi[:2] < (3, 4): | ||
| sys.exit("Running mypy with Python 3.3 or lower is not supported; please upgrade") | ||
| if vi[:3] == (3, 5, 0): | ||
| sys.exit("Running mypy with Python 3.5.0 is not supported; please upgrade") |
There was a problem hiding this comment.
I think it is worth it to specify that upgrading to a later version of 3.5 is possible. It isn't hard for me to imagine someone seeing this and thinking that they must use 3.6.x or newer to use mypy, which is not the impression we want. Perhaps ... please upgrade to Python 3.5.1 or newer?
mypy/main.py
Outdated
| be used. | ||
| """ | ||
| # Check for known bad Python versions. | ||
| vi = tuple(sys.version_info) |
There was a problem hiding this comment.
sys.version_info is already a tuple, so I think the tuple call is unnecessary.
|
OK, how about now?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4714