Add support for specifying multiple packages on the command line alongside modules #4733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
multiple-packages
branch
from
814e323 to
0430b1b
Compare
|
Are you going to fix the error?
|
|
CI output wasn't showing up when I looked before. I'll take a look later today |
eric-wieser
force-pushed
the
multiple-packages
branch
2 times, most recently
from
78d430c to
8fdc06a
Compare
|
Alright, fixed. |
|
Hm, we don't seem to have tests for -m and -p at all... Could you add some? They would go in test-data/unit/cmdline.test. |
|
Tests don't run at all locally for my machine, so I'm gonna hijack the CI to do my testing... (fails with |
eric-wieser
force-pushed
the
multiple-packages
branch
from
778a2aa to
5bf877b
Compare
eric-wieser
force-pushed
the
multiple-packages
branch
from
5bf877b to
53b7481
Compare
|
Ok, test added |
|
Don't use setup.py for tests, see README for instructions.
…On Wed, Mar 14, 2018, 21:46 Eric Wieser ***@***.***> wrote:
Ok, test added
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4733 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMrCjfLmYVPPtK1cB_ZbxTD2e8LUvks5tefI2gaJpZM4SpyQu>
.
|
|
Are you happy with the test I've added here? Seems to pass locally and on CI |
gvanrossum
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4732
Let me know how best to add tests for this, if you think they're needed.