Fix error message when assigning to read-only property #4863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#4756 Consider the following program: ```python class Parent: @Property def foobar(self) -> int: ... class Child(Parent): pass Child().foobar = 10 ``` Previously, mypy would report that the property `foobar` was defined in 'Child'. Now, it correctly reports it was defined in 'Parent'.
ilevkivskyi
approved these changes
Apr 5, 2018
Michael0x2a
deleted the
fix-error-message-when-assigning-to-readonly-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4756
Consider the following program:
Previously, mypy would report that the property
foobarwas defined in 'Child'. Now, it correctly reports it was defined in 'Parent'.