KEMBAR78
Improve error message for invalid tuple types like (int, str). #4173 by MentalMegalodon · Pull Request #5042 · python/mypy · GitHub
Skip to content

Improve error message for invalid tuple types like (int, str). #4173 #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2018
Merged

Improve error message for invalid tuple types like (int, str). #4173 #5042

merged 1 commit into from
May 14, 2018

Conversation

@MentalMegalodon
Copy link
Contributor

@MentalMegalodon MentalMegalodon commented May 14, 2018 •
edited by ilevkivskyi
Loading

Fixes #4173

ilevkivskyi
ilevkivskyi approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! I will merge when tests pass.

@msullivan msullivan merged commit ee2195a into python:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MentalMegalodon @ilevkivskyi @msullivan