Fix two option handling bugs in dmypy #5172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make sure to use the right options when processing pass3 semanal in triggers 2. Don't throw away `ignore_errors` when processing triggers Fixes #5168
ilevkivskyi
reviewed
Jun 8, 2018
| nodes = sorted(nodeset, key=key) | ||
|
|
||
| # TODO: ignore_all argument to set_file_ignored_lines | ||
| manager.errors.set_file_ignored_lines(file_node.path, file_node.ignored_lines) |
There was a problem hiding this comment.
It looks like this change breaks the # type: ignore in fine grained mode.
There was a problem hiding this comment.
Argh I thought I had run the tests >_>
ilevkivskyi
approved these changes
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_errorswhen processing triggersFixes #5168