KEMBAR78
Fix crash in module __getattr__ by ilevkivskyi · Pull Request #5292 · python/mypy · GitHub
Skip to content

Fix crash in module __getattr__ #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2018
Merged

Fix crash in module __getattr__ #5292

merged 3 commits into from
Jun 29, 2018

Conversation

@ilevkivskyi
Copy link
Member

The examples in tests crash with:

  File "/Users/ilevkivskyi/src/mypy/mypy/semanal.py", line 1613, in anal_type
    typ = t.accept(a)
  File "/Users/ilevkivskyi/src/mypy/mypy/types.py", line 204, in accept
    return visitor.visit_unbound_type(self)
  File "/Users/ilevkivskyi/src/mypy/mypy/typeanal.py", line 179, in visit_unbound_type
    typ = self.visit_unbound_type_nonoptional(t)
  File "/Users/ilevkivskyi/src/mypy/mypy/typeanal.py", line 215, in visit_unbound_type_nonoptional
    tvar_def = self.tvar_scope.get_binding(sym)
  File "/Users/ilevkivskyi/src/mypy/mypy/tvar_scope.py", line 78, in get_binding
    assert fullname is not None
AssertionError:

While debugging this I found some other controversial code. But I don't want to touch it in this same PR (also best solution for that other problem is not clear to me).

@ilevkivskyi ilevkivskyi requested a review from msullivan June 28, 2018 21:41
@ilevkivskyi ilevkivskyi merged commit c348b99 into python:master Jun 29, 2018
@ilevkivskyi ilevkivskyi deleted the fix-fullname-crash branch June 29, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msullivan msullivan msullivan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilevkivskyi @msullivan