KEMBAR78
Only use __getattr__ when node is not found by ilevkivskyi · Pull Request #5332 · python/mypy · GitHub
Skip to content

Only use __getattr__ when node is not found #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2018
Merged

Only use __getattr__ when node is not found #5332

merged 1 commit into from
Jul 8, 2018

Conversation

@ilevkivskyi
Copy link
Member

Fixes #5331

@ilevkivskyi ilevkivskyi requested a review from emmatyping July 8, 2018 14:59
emmatyping
emmatyping approved these changes Jul 8, 2018
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ilevkivskyi ilevkivskyi merged commit bc0b551 into python:master Jul 8, 2018
@ilevkivskyi ilevkivskyi deleted the fix-getattr branch July 8, 2018 18:29
@emmatyping emmatyping mentioned this pull request Jul 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilevkivskyi @emmatyping