Add missing fine-grained dependencies when using Type[X] #5607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `X.__init__` triggers uses of `Type[X]`, since `Type[X]` is callable and the signature is derived from `X.__init__` (or `__new__`). I also verified that this works end-to-end but I decided not to add a test case since the existing ones seem to provide enough coverage. This generates some dependencies that aren't necessary, but they seem pretty benign.
ilevkivskyi
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
X.__init__triggers uses ofType[X], sinceType[X]iscallable and the signature is derived from
X.__init__(or__new__).I also verified that this works end-to-end but I decided not to add a
test case since the existing ones seem to provide enough coverage.
This generates some dependencies that aren't necessary, but they seem
pretty benign.