Fix meet for tuple with instance #5641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Sep 19, 2018
mypy/meet.py
Outdated
| elif is_proper_subtype(t, self.s): | ||
| # A named tuple that inherits from a normal class | ||
| return t | ||
| elif (isinstance(self.s, Instance) and t.fallback.type == self.s.type): |
There was a problem hiding this comment.
It looks like the condition can never be true. Either move this to the above elif block or remove?
There was a problem hiding this comment.
Yes, good catch, I think this is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5640
Since generic tuple types are not supported,
map_instance_to_supertypeis not needed here. This solution doesn't work for general multiple inheritance, for example the test case will not work withif isinstance(o, BaseTuple), but this is exactly the same as for e.g. two instance types.