Do pass 1 semanatic analysis on the FuncDef of decorated functions #5654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This populates fullname properly, fixing a crash where a decorated function is used as a type annotation in an import cycle, as well as fixing an obscure bug in sys.platform checks inside decorated functions. Fixes #5652.
ilevkivskyi
approved these changes
Sep 20, 2018
| self.analyze_lvalue(lval, explicit_type=s.type is not None) | ||
|
|
||
| def visit_func_def(self, func: FuncDef) -> None: | ||
| def visit_func_def(self, func: FuncDef, decorated: bool = False) -> None: |
There was a problem hiding this comment.
I would document the argument and the need for it, because it is not obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This populates fullname properly, fixing a crash where a decorated
function is used as a type annotation in an import cycle,
as well as fixing an obscure bug in sys.platform checks inside
decorated functions.
Fixes #5652.