Fix stubgen breakage #5673
Merged
Fix stubgen breakage #5673
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run as a script, stubgen's sys.path won't contain the current directory, but stubgen needs to be able to run on modules in the current directory. Fixes #4571.
|
Hm, I'm not sure this fixes the problem. IIRC if you run stubgen recursively it will not pick up the children packages. Have you tested this with the |
|
|
gvanrossum
approved these changes
Sep 26, 2018
|
Yeah, that's my theory. No reason to add complication that won't change behavior in an important way. |
|
Great, glad this was fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '' back to sys.path when running stubgen
When run as a script, stubgen's sys.path won't contain the current
directory, but stubgen needs to be able to run on modules in the
current directory.
Fixes #4571.