Document ClassVar #5733
Merged
Document ClassVar #5733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @JukkaL might want to review this. |
JukkaL
reviewed
Oct 4, 2018
|
Hey @nanjekyejoannah, do you want to push an updated version in response to Jukka's review? There's still time to get this cherry-picked in the upcoming 0.640 release. |
nanjekyejoannah
commented
Oct 9, 2018
There was a problem hiding this comment.
@gvanrossum Apologies for a late response. Been traveling for ages :). I have made the necessary changes. @JukkaL PTAL.
JukkaL
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5546.
I have added a section in the class basics documentation with details on when, how and when not to use ClassVar.
cc @ilevkivskyi