KEMBAR78
Use actual variable name for failed enum calls by ilevkivskyi · Pull Request #5810 · python/mypy · GitHub
Skip to content

Use actual variable name for failed enum calls #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

Use actual variable name for failed enum calls #5810

merged 1 commit into from
Oct 19, 2018

Conversation

@ilevkivskyi
Copy link
Member

This fixes a crash discovered in internal codebases.

msullivan
msullivan approved these changes Oct 19, 2018
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@ilevkivskyi ilevkivskyi merged commit e4a5ea6 into python:master Oct 19, 2018
@ilevkivskyi ilevkivskyi deleted the wrong-enum branch October 19, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msullivan msullivan msullivan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilevkivskyi @msullivan