Make stubgen less aggressive about walking C extension modules #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #5814 made stubgen try to walk as a module any attribute of a C extension module of module type. This is too aggressive: mypyc generated extension modules will often have attributes of module type from imports that do not correspond to actual modules. This causes a stubgen test to fail under mypy_mypyc while trying to import `mypy.errors.os`, since `mypy.errors` imports `os`. Only walk such a submodule when its `__name__` matches it being a submodule.
|
Before I approve this, a question for @pkerichang: Can you test this with your pybind11 setup? (This could go awry if pybind11 doesn't set |
gvanrossum
approved these changes
Nov 16, 2018
|
I'm going to go ahead and merge this now, so that mypyc tests get fixed. @pkerichang, if this breaks what you were trying to do in #5814, follow up with us |
|
Sorry for the late response; this works fine on my end. Thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5814 made stubgen try to walk as a module any attribute of a C
of a C extension module of module type. This is too aggressive: mypyc
generated extension modules will often have attributes of module type
from imports that do not correspond to actual modules.
This causes a stubgen test to fail under mypy_mypyc while trying to
import
mypy.errors.os, sincemypy.errorsimportsos.Only walk such a submodule when its
__name__matches it being asubmodule.