KEMBAR78
Fix ctypes plugin trying to look up bytes in Python 2 by dgelessus · Pull Request #5924 · python/mypy · GitHub
Skip to content

Fix ctypes plugin trying to look up bytes in Python 2 #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2018
Merged

Fix ctypes plugin trying to look up bytes in Python 2 #5924

merged 2 commits into from
Nov 20, 2018

Conversation

dgelessus
Copy link
Contributor

Fixes #5922.

@dgelessus
Split floatdict.pyi fixture into Python 2 and 3 variants
6e4f28a 
This is because bytes should only be defined in Python 3, and unicode
should only be defined in Python 2. sys.version checks don't work in
test fixtures, so the only way to implement this is to split the
fixture into two separate files.
@dgelessus
Fix ctypes plugin trying to look up bytes in Python 2 (fixes python#5922
b484669 
)
ilevkivskyi
ilevkivskyi approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! LGTM.

@ilevkivskyi ilevkivskyi merged commit 7819cff into python:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgelessus @ilevkivskyi