KEMBAR78
Ensure that non-total TypedDicts can be falsy by henribru · Pull Request #7745 · python/mypy · GitHub
Skip to content

Ensure that non-total TypedDicts can be falsy #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2019
Merged

Ensure that non-total TypedDicts can be falsy #7745

merged 2 commits into from
Oct 18, 2019

Conversation

henribru
Copy link
Contributor

Fixes #7743

ilevkivskyi
ilevkivskyi approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks very good, I made a little tweak to the test to make it a bit stronger.

@ilevkivskyi ilevkivskyi merged commit 0f4bf10 into python:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive with --warn-unreachable: TypedDict may be empty

2 participants

@henribru @ilevkivskyi