KEMBAR78
Fix 7807 by goodmami · Pull Request #7820 · python/mypy · GitHub
Skip to content

Conversation

goodmami
Copy link
Contributor

@goodmami goodmami commented Oct 30, 2019

Commit a8c7947 removed the old parser after the new one had taken
over, but the ability to use mypy.parse as a script for dumping
parse trees was also removed, perhaps by accident. This commit adds
that functionality back as the misc/dump-ast.py script.

This partially resolves issue #7807. What remains is editing the wiki accordingly.

Commit a8c7947 removed the old parser after the new one had taken
over, but the ability to use `mypy.parse` as a script for dumping
parse trees was also removed, perhaps by accident. This commit adds
that functionality back as a script under `misc/`.
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the AST dump functionality back! This will helpful for new contributors, in particular. Looks good.

Optionally, it would nice to have a few test cases for this (in a separate PR), but since this is a developer-only utility, it's not very important.

@JukkaL JukkaL merged commit 270afec into python:master Oct 30, 2019
@goodmami goodmami deleted the fix-7807 branch October 30, 2019 14:49
@dhilst
Copy link

dhilst commented Jul 25, 2020

@JukkaL I just came across this. The wiki is outdated yet, I'm willing to update it, is there any review process to edit the wiki? I never contributed to a wiki inside github yet, only PRs.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 31, 2020

@dhilst We don't have a specific review process for the wiki (the wiki has been somewhat neglected). One way would be to create an issue here with the proposed changes. Or maybe you can just edit a wiki page, and create an issue where you link to your changes, so that somebody can check them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants