Fix error when assigning a ternary with an empty collection to a union type variable #7892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Nov 6, 2019
test-data/unit/check-unions.test
Outdated
| [case testAssignUnionWithTenaryExprWithEmptyCollection] | ||
| from typing import Dict, List, Union | ||
| x: Union[int, List[int]] = 1 if "" else [] | ||
| y: Union[int, Dict[int, int]] = 1 if "" else {} |
There was a problem hiding this comment.
Could you please also add the opposite conditional expressions to the test (since the current inference logic seems to be a bit asymmetric):
x: Union[int, List[int]] = [] if bool() else 1
y: Union[int, Dict[int, int]] = {} if bool() else 1
There was a problem hiding this comment.
Very reasonable to make it symmetric. See 47f9f25
ilevkivskyi
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7780