Fix compiled dmypy on Windows #7929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that the mechanism for transmitting Options to the daemon on Windows used snapshot/apply_changes and those don't play well with read-only attributes when compiled. I've fixed this in the most expedient way for now but will do some follow ups to clean up this mechanism and hopefully test this on Windows in CI.
|
This would be worth a point release except that the paucity of reports makes me suspect nobody would care? I don't know. |
ilevkivskyi
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the mechanism for transmitting Options to the daemon
on Windows used snapshot/apply_changes and those don't play well with
read-only attributes when compiled.
I've fixed this in the most expedient way for now but will do some
follow ups to clean up this mechanism and hopefully test this on
Windows in CI.