KEMBAR78
Fix false positive: return Any from a function declared to return object by TH3CHARLie · Pull Request #8011 · python/mypy · GitHub
Skip to content

Fix false positive: return Any from a function declared to return object #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2019
Merged

Fix false positive: return Any from a function declared to return object #8011

merged 2 commits into from
Nov 26, 2019

Conversation

TH3CHARLie
Copy link
Collaborator

resolves #8008

@TH3CHARLie TH3CHARLie mentioned this pull request Nov 26, 2019
Closed
ilevkivskyi
ilevkivskyi approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Just one suggestion about indentation.

@TH3CHARLie @ilevkivskyi
Update identation
548cc01 
Co-Authored-By: Ivan Levkivskyi <levkivskyi@gmail.com>
@TH3CHARLie
Copy link
Collaborator Author

Thanks for the review, the indentation has been updated

@ilevkivskyi ilevkivskyi merged commit 253bdb5 into python:master Nov 26, 2019
@TH3CHARLie TH3CHARLie deleted the fix-any-return branch November 26, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive on returning Any from function declared to return object

2 participants

@TH3CHARLie @ilevkivskyi