KEMBAR78
Recommend typing_extensions instead of mypy_extensions for TypedDict by ilevkivskyi · Pull Request #8023 · python/mypy · GitHub
Skip to content

Conversation

@ilevkivskyi
Copy link
Member

Now that TypedDict is an official feature I think this would make sense.

@ilevkivskyi ilevkivskyi requested a review from JukkaL November 27, 2019 16:00
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What about also documenting that in Python 3.8 TypedDict can be imported from typing?

@ilevkivskyi
Copy link
Member Author

What about also documenting that in Python 3.8 TypedDict can be imported from typing?

OK, I will add a short note about this (Python 3.8 is still new so I think we can use typing_extensions in the examples).

@ilevkivskyi ilevkivskyi merged commit f78effd into python:master Nov 27, 2019
@ilevkivskyi ilevkivskyi deleted the typing-extensions-typeddict-docs branch November 27, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants