KEMBAR78
Better error message when using pyd file as stubgen by TH3CHARLie · Pull Request #8063 · python/mypy · GitHub
Skip to content

Better error message when using pyd file as stubgen #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2019
Merged

Better error message when using pyd file as stubgen #8063

merged 3 commits into from
Dec 3, 2019

Conversation

TH3CHARLie
Copy link
Collaborator

resolves #8035

emmatyping
emmatyping reviewed Dec 3, 2019
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I have one suggestion but otherwise looks good.

emmatyping
emmatyping approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@TH3CHARLie
Copy link
Collaborator Author

Thanks for the review

@JukkaL JukkaL merged commit e05bd1c into python:master Dec 3, 2019
@TH3CHARLie TH3CHARLie deleted the better-error-msg-for-pyd-file branch December 4, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stubgen pyd file utf-8 error

3 participants

@TH3CHARLie @emmatyping @JukkaL