Don't simplify out ErasedType from unions during type inference #8095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Dec 5, 2019
test-data/unit/check-inference.test
Outdated
|
|
||
| x: Optional[str] | ||
|
|
||
| pagelets = filter(None, [x]) |
There was a problem hiding this comment.
Test that the type of pagelets is List[str]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8093
The fix is kind of simple, we really need to keep all
ErasedTypes intact to preserve the existing type inference logic, but it is also long because I need to thread the flag down like dozen function calls.The issue itself btw highlight how fragile is current type inference logic (note that
expand_type()implicitly callsmake_simplified_union()too, but I think that one doesn't need to be updated because it shouldn't be called with any erased components).