[mypyc] Add primitives for list, str and tuple slicing #9283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes specialized ops for list, str and tuple slicing.
It doesn't preserve semantics (None for missing begin/end).
It should fail right now. I'll update it later after I've validated that it fails as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up some microbenchmarks from 40% (list) to 100% (str)
when I run them on Ubuntu 20.04.
Non-default strides aren't optimized, since they are fairly rare.
a[::-1]for lists might be worth special casing in the future. Also, oncewe have primitives for
bytes, it should also be special cased.Fixes mypyc/mypyc#725.