KEMBAR78
[mypyc] Make multiple assignment faster(1st stage) by TH3CHARLie · Pull Request #9575 · python/mypy · GitHub
Skip to content

[mypyc] Make multiple assignment faster(1st stage) #9575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

[mypyc] Make multiple assignment faster(1st stage) #9575

merged 1 commit into from
Oct 14, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie commented Oct 10, 2020 •
edited
Loading

relates mypyc/mypyc#729

This PR makes simple cases like y, x = x, y faster.

I tend to do some future improvement based on this PR(for example, supporting ListExpr as @JukkaL suggested), nevertheless, this PR itself should cover the most frequent use case.

@TH3CHARLie
Copy link
Collaborator Author

Some imprecise benchmark results:

Before:

............
interpreted: 0.167262s (avg of 6 iterations; stdev 0.61%)
compiled:    0.163983s (avg of 6 iterations; stdev 0.48%)

compiled is 1.020x faster

After:

running multiple_assignment
............
interpreted: 0.164994s (avg of 6 iterations; stdev 0.52%)
compiled:    0.055589s (avg of 6 iterations; stdev 0.69%)

compiled is 2.968x faster

@TH3CHARLie TH3CHARLie requested a review from JukkaL October 10, 2020 23:29
@TH3CHARLie
Copy link
Collaborator Author

I believe the failed StubgenCliParseSuite.test_walk_packages is not related to this PR

JukkaL
JukkaL approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This fixes a bad performance bottleneck.

@JukkaL JukkaL merged commit e2274a6 into python:master Oct 14, 2020
@TH3CHARLie TH3CHARLie deleted the multiple-assignment-mypyc branch October 14, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TH3CHARLie @JukkaL