stubgen: properly convert overloaded functions #9613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadrik
commented
Oct 19, 2020
| self.add_typing_import("Any") | ||
| annotation = ": {}".format(self.typing_name("Any")) | ||
| elif annotated_type and not is_self_arg: | ||
| elif annotated_type and not is_self_arg and not is_cls_arg: |
There was a problem hiding this comment.
without this change I was getting an erroneous type for cls:
class A:
@typing.overload
@classmethod
def g(cls: Any, x: typing.Tuple[int, int]) -> int: ...
chadrik
force-pushed
the
stubgen-overload
branch
from
3a68e56 to
423f912
Compare
JukkaL
reviewed
Oct 23, 2020
mypy/stubgen.py
Outdated
| return is_abstract | ||
| elif (isinstance(expr.expr, NameExpr) and | ||
| (expr.expr.name == 'typing' or | ||
| self.import_tracker.reverse_alias.get('typing')) and |
There was a problem hiding this comment.
Should this be expr.expr.name in ('typing', self.import_tracker.reverse_alias.get('typing'))? Maybe add test case that uses import typing as t or similar.
There was a problem hiding this comment.
Good catch. This was not working correctly for abc.abstractmethod|property, which is where I copied it from. I fixed it and added a test for both.
chadrik
force-pushed
the
stubgen-overload
branch
2 times, most recently
from
d144d15 to
c4a2ce4
Compare
|
This should be all ready to merge |
|
Hi, this is still ready to merge! |
chadrik
force-pushed
the
stubgen-overload
branch
from
c4a2ce4 to
3e55df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves
stubgento convert functions that have been decorated with@overload.stubgenis useful not just for creating a starting point for manually authoring stubs, but also to create automated workflows to continuously regenerate stubs for projects that want to provide stubs to third parties to hide runtime complexity from mypy.Test Plan
Added two new tests.