TypedDict: Fix casefolding of 'missing keys' error message #9757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the message accidentally converted all identifiers to lowercase. By rephrasing the message, I avoided complicating the `format_key_list()` function.
intgr
force-pushed
the
fix-TypedDict-missing-key-casefolding
branch
from
abf3881 to
ca8aff5
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: - dragonchain/webserver/helpers_utest.py:169:48: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/webserver/helpers_utest.py:169:48: error: Missing key 'options' for TypedDict "custom_index"
- dragonchain/webserver/helpers_utest.py:172:48: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/webserver/helpers_utest.py:172:48: error: Missing key 'options' for TypedDict "custom_index"
- dragonchain/webserver/helpers_utest.py:175:48: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/webserver/helpers_utest.py:175:48: error: Missing key 'options' for TypedDict "custom_index"
- dragonchain/lib/database/redisearch_utest.py:71:56: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/lib/database/redisearch_utest.py:71:56: error: Missing key 'options' for TypedDict "custom_index"
|
1 similar comment
|
Diff from mypy_primer, showing the effect of this PR on open source code: - dragonchain/webserver/helpers_utest.py:169:48: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/webserver/helpers_utest.py:169:48: error: Missing key 'options' for TypedDict "custom_index"
- dragonchain/webserver/helpers_utest.py:172:48: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/webserver/helpers_utest.py:172:48: error: Missing key 'options' for TypedDict "custom_index"
- dragonchain/webserver/helpers_utest.py:175:48: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/webserver/helpers_utest.py:175:48: error: Missing key 'options' for TypedDict "custom_index"
- dragonchain/lib/database/redisearch_utest.py:71:56: error: Key 'options' missing for TypedDict "custom_index"
+ dragonchain/lib/database/redisearch_utest.py:71:56: error: Missing key 'options' for TypedDict "custom_index"
|
JelleZijlstra
approved these changes
Nov 25, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the message accidentally converted all identifiers to
lowercase. By rephrasing the message, I avoided complicating the
format_key_list()function.Test Plan
Added a test case as well.
Code:
Old output:
Output after my changes: