[mypyc] Some tagged integer micro-optimizations #9801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently on Windows |
ilevkivskyi
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
PyLong_FromLonginstead ofPyLong_FromSsize_tsince it's faster(at least on Python 3.8) and happens to work the same on macOS and Linux.
This is an extremely hot operation.
Add some
unlikely(...)andlikely(...)to tagged integer primitives.Overall these made the Richards benchmark about 4% faster, which was a
surprisingly big improvement.
(I'm sure there are still some remaining easy performance wins in tagged
integer operations.)
Work on mypyc/mypyc#757.